Ethan Girouard eta357
eta357 pushed to 42-create-profile-page at LibreTunes/LibreTunes 2024-11-04 04:22:01 +00:00
35abbe19ee Merge branch '126-create-global-logged-in-user-resource' into 42-create-profile-page
2b380d7787 Refetch logged in user on login/signup
8ac3a87c58 Add global logged in user Resource
43a5b519fd Add API endpoint to get logged in user
251d567863 Return logged in user from login endpoint
Compare 47 commits »
eta357 opened issue LibreTunes/LibreTunes#129 2024-11-04 02:49:32 +00:00
Enable scrolling for home components
eta357 deleted branch 126-create-global-logged-in-user-resource from LibreTunes/LibreTunes 2024-11-03 22:23:35 +00:00
eta357 pushed to main at LibreTunes/LibreTunes 2024-11-03 22:23:34 +00:00
186c622e6f Merge pull request 'Create global logged in user resource' (#128) from 126-create-global-logged-in-user-resource into main
2b380d7787 Refetch logged in user on login/signup
8ac3a87c58 Add global logged in user Resource
43a5b519fd Add API endpoint to get logged in user
251d567863 Return logged in user from login endpoint
Compare 5 commits »
eta357 closed issue LibreTunes/LibreTunes#126 2024-11-03 22:23:33 +00:00
Create global logged in user resource
eta357 merged pull request LibreTunes/LibreTunes#128 2024-11-03 22:23:33 +00:00
Create global logged in user resource
eta357 created pull request LibreTunes/LibreTunes#128 2024-11-03 22:23:19 +00:00
Create global logged in user resource
eta357 opened issue LibreTunes/LibreTunes#127 2024-11-03 22:22:23 +00:00
Switch from dotenv to dotenvy
2b380d7787 Refetch logged in user on login/signup
8ac3a87c58 Add global logged in user Resource
43a5b519fd Add API endpoint to get logged in user
251d567863 Return logged in user from login endpoint
Compare 4 commits »
eta357 commented on issue LibreTunes/LibreTunes#126 2024-11-03 21:18:39 +00:00
Create global logged in user resource

!start

eta357 opened issue LibreTunes/LibreTunes#126 2024-11-03 21:18:29 +00:00
Create global logged in user resource
eta357 commented on pull request LibreTunes/LibreTunes#124 2024-11-03 18:08:57 +00:00
95-fix-home-screen-account-button-ui

I think you were right originally about having a global logged in user object on the frontend. I can help with the development of this. Adding this would make writing several other pages easier…

eta357 commented on pull request LibreTunes/LibreTunes#124 2024-11-03 18:06:56 +00:00
95-fix-home-screen-account-button-ui

Turning this into an API endpoint is actually dangerous, as the returned user contains the password hash. This field should be set to None before returning. Although technically the user is only returned if that user has already logged in (and therefore should already know the password), this is still not a good practice. I know I advised you to use this function, but we should add this protection. However this code may change anyways, see my other comment about potentially adding a new function returning an Option<User>.

eta357 created repository eta357/dashcam-immich-ingest 2024-11-02 18:21:53 +00:00
eta357 suggested changes for LibreTunes/LibreTunes#124 2024-11-02 03:24:51 +00:00
95-fix-home-screen-account-button-ui

See comment about the duplicate requests. I'm also debating changing how get_user() works (for the profile page work I'm doing) to return an Result<Option<User>, ...> instead of a Result<User, ...>, because there is a strong distinction between not having a user logged in, and a server error occurring when checking if a user is logged in.

eta357 commented on pull request LibreTunes/LibreTunes#124 2024-11-02 03:24:51 +00:00
95-fix-home-screen-account-button-ui

Here you're making two separate calls to get_user, each of which causes an API request. In the interest of performance, it would be best to do this as a single query.

eta357 pushed to main at LibreTunes/LibreTunes 2024-11-02 02:58:43 +00:00
1f70da1747 Merge pull request 'Added webp files' (#125) from 121-add-webp-files-to-gitignore into main
a70de76c4d Added webp files
Compare 2 commits »
eta357 merged pull request LibreTunes/LibreTunes#125 2024-11-02 02:58:42 +00:00
Added webp files
eta357 closed issue LibreTunes/LibreTunes#121 2024-11-02 02:58:42 +00:00
Add webp files to gitignore
eta357 opened issue LibreTunes/LibreTunes#123 2024-11-01 18:32:40 +00:00
Implement Like/Dislike for songs in SongList