Ethan Girouard eta357
0 Followers · 4 Following
Repositories
2
 Projects Packages Public Activity Starred Repositories
11
eta357 commented on pull request LibreTunes/LibreTunes#124 2024-11-02 03:24:51 +00:00
95-fix-home-screen-account-button-ui

Here you're making two separate calls to get_user, each of which causes an API request. In the interest of performance, it would be best to do this as a single query.

eta357 suggested changes for LibreTunes/LibreTunes#124 2024-11-02 03:24:51 +00:00
95-fix-home-screen-account-button-ui

See comment about the duplicate requests. I'm also debating changing how get_user() works (for the profile page work I'm doing) to return an Result<Option<User>, ...> instead of a Result<User, ...>, because there is a strong distinction between not having a user logged in, and a server error occurring when checking if a user is logged in.

eta357 pushed to main at LibreTunes/LibreTunes 2024-11-02 02:58:43 +00:00
1f70da1747 Merge pull request 'Added webp files' (#125) from 121-add-webp-files-to-gitignore into main
a70de76c4d Added webp files
Compare 2 commits »
eta357 closed issue LibreTunes/LibreTunes#121 2024-11-02 02:58:42 +00:00
Add webp files to gitignore
eta357 merged pull request LibreTunes/LibreTunes#125 2024-11-02 02:58:42 +00:00
Added webp files
eta357 opened issue LibreTunes/LibreTunes#123 2024-11-01 18:32:40 +00:00
Implement Like/Dislike for songs in SongList
eta357 opened issue LibreTunes/LibreTunes#122 2024-11-01 18:32:20 +00:00
Implement play/pause for songs in SongList
eta357 opened issue LibreTunes/LibreTunes#121 2024-11-01 18:27:17 +00:00
Add webp files to gitignore
eta357 commented on issue LibreTunes/LibreTunes#104 2024-10-26 02:58:09 +00:00
Use stylance for scoped CSS

!start

eta357 commented on pull request LibreTunes/LibreTunes#118 2024-10-25 20:15:34 +00:00
Add added_date column to songs table #100

This is good, except for a few things:

  • You didn't quite follow the format of the migration folder name.
  • In order to access the data in this column, add a field to the Song struct in…
eta357 deleted branch 119-fix-docker-compose-missing-libretunesimages-volume from LibreTunes/LibreTunes 2024-10-25 19:40:12 +00:00
eta357 pushed to main at LibreTunes/LibreTunes 2024-10-25 19:40:12 +00:00
f299254d55 Merge pull request 'Fix Docker compose missing libretunes-images volume' (#120) from 119-fix-docker-compose-missing-libretunesimages-volume into main
14aa4d236e Add libretunes-images to volumes
Compare 2 commits »
eta357 closed issue LibreTunes/LibreTunes#119 2024-10-25 19:40:11 +00:00
Fix Docker compose missing libretunes-images volume
eta357 merged pull request LibreTunes/LibreTunes#120 2024-10-25 19:40:11 +00:00
Fix Docker compose missing libretunes-images volume
eta357 created pull request LibreTunes/LibreTunes#120 2024-10-25 18:29:06 +00:00
Fix Docker compose missing libretunes-images volume
14aa4d236e Add libretunes-images to volumes
eta357 commented on issue LibreTunes/LibreTunes#119 2024-10-25 18:28:08 +00:00
Fix Docker compose missing libretunes-images volume

!start

eta357 opened issue LibreTunes/LibreTunes#119 2024-10-25 18:27:58 +00:00
Fix Docker compose missing libretunes-images volume
eta357 opened issue LibreTunes/LibreTunes#117 2024-10-22 19:26:41 +00:00
Fix missing libretunes-images volume in Docker compose
eta357 pushed to main at LibreTunes/LibreTunes 2024-10-16 17:48:15 +00:00
3cfcacc9ba Merge pull request 'Setup routing for image and audio assets based on environment variables' (#107) from 35-make-asset-paths-configurable into main
f39d93bd0c Change audio and image path Docker comopse settings
e90ea56d14 Remove TODO
b222b7911f Add example environment variables and update docker-compose
a43955726a Setup routing for image and audio assets based on environment variables
Compare 5 commits »