LibreTunes/LibreTunes
7
1
Fork 0
Code Issues 24 Pull Requests Actions Packages Releases Activity

Add added_date column to songs table #100 #118

Merged
eta357 merged 5 commits from 100-add-addeddate-column-to-songs-table into main 2024-12-15 23:57:21 +00:00
Conversation 1 Commits 5 Files Changed 7 +16
pubsafe commented 2024-10-24 03:17:45 +00:00
Member
Copy Link
No description provided.
pubsafe added 1 commit 2024-10-24 03:17:48 +00:00
Add added_date column to songs table #100
All checks were successful
Push Workflows / docs (push) Successful in 2m46s
Details
Push Workflows / test (push) Successful in 5m8s
Details
Push Workflows / leptos-test (push) Successful in 6m49s
Details
Push Workflows / build (push) Successful in 7m46s
Details
Push Workflows / docker-build (push) Successful in 15m7s
Details
53805d8793
eta357 commented 2024-10-25 20:15:34 +00:00
Owner
Copy Link

This is good, except for a few things:

  • You didn't quite follow the format of the migration folder name. I believe the rest of the folder name is comprised of the time of the migration, just rename the folder and include the rough time you created it.
  • In order to access the data in this column, add a field to the Song struct in models.rs to store this date. It should be represented as an Option<Date> so that it isn't necessary to specify a date when inserting into the database.
This is good, except for a few things: - You didn't quite follow the format of the migration folder name. I believe the rest of the folder name is comprised of the time of the migration, just rename the folder and include the rough time you created it. - In order to access the data in this column, add a field to the Song struct in `models.rs` to store this date. It should be represented as an `Option<Date>` so that it isn't necessary to specify a date when inserting into the database.
eta357 added the
type
feature
 label 2024-12-01 02:06:05 +00:00
eta357 added 3 commits 2024-12-15 22:20:31 +00:00
Rename add_songs_added_date migration 8fbc733b6b
Merge branch 'main' into 100-add-addeddate-column-to-songs-table 9f39c9b3fd
Add added_date field to Song and SongData
Some checks failed
Push Workflows / docs (push) Successful in 2m8s
Details
Push Workflows / build (push) Failing after 2m53s
Details
Push Workflows / test (push) Successful in 5m7s
Details
Push Workflows / leptos-test (push) Successful in 6m16s
Details
Push Workflows / docker-build (push) Failing after 14m38s
Details
b7b6406c2d
eta357 added 1 commit 2024-12-15 23:11:01 +00:00
Merge branch '172-fix-unexpected-cfg-condition-name-wasmbindgenunstabletestcoverage' into 100-add-addeddate-column-to-songs-table
Some checks failed
Push Workflows / docs (push) Successful in 2m49s
Details
Push Workflows / test (push) Successful in 7m19s
Details
Push Workflows / leptos-test (push) Successful in 8m53s
Details
Push Workflows / build (push) Successful in 9m36s
Details
Push Workflows / docker-build (push) Failing after 15m33s
Details
ec65d099f1
eta357 merged commit 414f507ef9 into main 2024-12-15 23:57:21 +00:00
eta357 deleted branch 100-add-addeddate-column-to-songs-table 2024-12-15 23:57:21 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
backend
Pertaining to the API or back end of the web app
cicd
Relating to continuous integration / continuous deployment
dependencies
docs
Documentation work
frontend
Related to the UI or front end of the web app
meta
Related to the project itself
status
done
Work has been completed
status
in progress
Work is in progress
status
in review
Under review to be merged
status
todo
Work is planned, but has not yet started
type
bug
An issue with an existing feature
type
feature
A new feature
No Label
type
feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clbertolini dannyzou18 ecco257 eta357 hifwiend LibreTunes-Bot pubsafe
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LibreTunes/LibreTunes#118
No description provided.
Delete Branch "100-add-addeddate-column-to-songs-table"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?